Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test_reusable_strategies_are_all_reusable #1893

Merged
merged 1 commit into from Mar 24, 2019
Merged

Fix flaky test_reusable_strategies_are_all_reusable #1893

merged 1 commit into from Mar 24, 2019

Conversation

Zalathar
Copy link
Contributor

Fixes #1892.

It's slightly annoying that this won't automatically detect when HypothesisDeprecationWarning is no longer necessary (when #1860 becomes a hard error), but I don't know of a reasonable way to make that happen.

@Zalathar Zalathar added the flaky-tests for when our tests only sometimes pass label Mar 24, 2019
@Zalathar
Copy link
Contributor Author

I got clever and tried to add @example(st.floats(0.0, -0.0)), but that doesn't work because @example interprets an unsatisfied assumption as failure. So I had to take it back out.

@Zalathar Zalathar merged commit f192ddb into HypothesisWorks:master Mar 24, 2019
@Zalathar Zalathar deleted the flaky-reusable-values branch March 24, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zac-HD Zac-HD Zac-HD approved these changes

Assignees
No one assigned
Labels
flaky-tests for when our tests only sometimes pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zalathar @Zac-HD