Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit terminal strategies for Lark #2073

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Aug 11, 2019

Closes #1806, in that it turns out to make supporting @declared indents possible for hypothesmith without weird hacks, and handling of identifiers a lot more efficient.

@Zac-HD Zac-HD added the new-feature entirely novel capabilities or strategies label Aug 11, 2019
@Zac-HD
Copy link
Member Author

Zac-HD commented Sep 2, 2019

Ping @HypothesisWorks/hypothesis-python-contributors for review? This will be really useful for a downstream project of mine, and if we upstream it others can take advantage too 😄

Copy link
Contributor

@rsokl rsokl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I spent some time reading about lark so that I could do a more educated review. That being said, I am not really able to weigh-in on any of the design aspects of this PR.

@Zac-HD Zac-HD merged commit 2a68481 into HypothesisWorks:master Sep 4, 2019
@Zac-HD Zac-HD deleted the lark-python branch September 4, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature entirely novel capabilities or strategies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generating Python code (via Lark)
2 participants