Suport platforms where __file__ is not defined
#2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
no-__file__
branch
2 times, most recently
from
5e43ecf
to
2d703ec
Compare
alexwlchan
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
such as
zipapporPyOxidizer.is_hypothesis_filewill always returnFalse, becausehypothesis.__file__is not defined. This weakens our traceback elision somewhat; it's clearly better than a crash but if we get a non-trivial user base on these platforms it's probably possible to do better.__file__, or theimportlib_resourcesbackport to load the list of TLDs. Anyone in the third category is encouraged to contact us, because I'm not adding a conditional dependency without any evidence that it would actually be useful.Closes #2196.