Rewrite simple filters for bounded integers()
#2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
added
enhancement
Zac-HD
force-pushed
the
efficient-filter
branch
from
1767cbb
to
ecd41fc
Compare
Zac-HD
force-pushed
the
efficient-filter
branch
2 times, most recently
from
e1861b1
to
90a0626
Compare
rsokl
reviewed
Feb 14, 2021
Zac-HD
force-pushed
the
efficient-filter
branch
from
c0cfdef
to
2e3dd23
Compare
rsokl
requested changes
Feb 24, 2021
hypothesis-python/src/hypothesis/strategies/_internal/strategies.py
Outdated
Show resolved
Hide resolved
hypothesis-python/src/hypothesis/strategies/_internal/strategies.py
Outdated
Show resolved
Hide resolved
This is a minimal proof-of-concept for predicate rewriting, sufficient to demonstrate that it works without breaking anything else. Equally importantly, it adds clear hooks for future work to allow open collaboration.
Zac-HD
force-pushed
the
efficient-filter
branch
from
2e3dd23
to
37b9f12
Compare
rsokl
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the first piece of #2701.
It demonstrates that the concept works, handles the tricky interactions with LazyStrategy and chained filters (though
one_of()is left for future work), and provides obvious locations for future contributions - such as copying this logic forfloats(). Further discussion of how the overall plan can be broken down into pull requests can be found at #2701, along with next steps.