Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of forward references in get_type_hints #3521

Merged
merged 8 commits into from Dec 4, 2022
Merged

Improve handling of forward references in get_type_hints #3521

merged 8 commits into from Dec 4, 2022

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented Dec 3, 2022

Closes #3519

@rsokl rsokl changed the title Improve handling of fwd-reference in get_type_hints Improve handling of forward references in get_type_hints Dec 3, 2022
@rsokl rsokl mentioned this pull request Dec 3, 2022
Closed
Zac-HD
Zac-HD approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉

@Zac-HD Zac-HD merged commit d56fe3c into master Dec 4, 2022
@Zac-HD Zac-HD deleted the fwd-refs branch December 4, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zac-HD Zac-HD Zac-HD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hypothesis fails with ForwardRefs and recursive pydantic models
2 participants
@rsokl @Zac-HD