Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename st.characters() args #3742

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Sep 15, 2023

Closes #3740 (comment)

This PR renames white/blacklist characters to include/exclude, and renames the white/blacklist categories arguments to mutally-exclusive categories/exclude_categories. These new names more clearly describe the semantics of these arguments, and align with community best practice. The old names remain in place, and while now undocumented do not (yet) emit a deprecation warning.

@Zac-HD Zac-HD added the enhancement it's not broken, but we want it to be better label Sep 15, 2023
@Zac-HD Zac-HD force-pushed the update-characters-args branch 4 times, most recently from cce7faa to 661e56d Compare September 16, 2023 08:57
@Zac-HD Zac-HD marked this pull request as ready for review September 16, 2023 08:57
@Zac-HD Zac-HD merged commit caadcaa into HypothesisWorks:master Sep 16, 2023
47 checks passed
@Zac-HD Zac-HD deleted the update-characters-args branch September 16, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of 'blacklist' and 'whitelist' in strategies.characters
1 participant