Rewrite regex filters on text() and binary()
#3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
more-rewrites
branch
2 times, most recently
from
b1b7e80
to
0c4ead0
Compare
|
OK, it looks like this basically works; it's just that the pretty-printer ...doesn't pretty-print bound methods of compiled regex patterns under PyPy. Maybe something to do with |
Zac-HD
force-pushed
the
more-rewrites
branch
2 times, most recently
from
ec7dad6
to
6816a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that all the hard parts were handled in #3730 and #3839, which is pretty convenient!
Closes #3795; length bounds are already done and I don't think any of the other listed-as-optional ideas are worth the trouble.