Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32-bit architecture detection in pandas index test #3905

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

roehling
Copy link
Contributor

The sys.maxsize attribute stores the maximum size of the signed size type, so is_32bit is never True. Fixing this may also make the special-casing for windows obsolete (but I have no windows machine to verify that).

@Zac-HD Zac-HD added the tests/build/CI about testing or deployment *of* Hypothesis label Mar 2, 2024
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @roehling!

Happily we have both 32-bit and 64-bit Windows in our CI system, and unfortunately we do still need the windows condition!

@Zac-HD Zac-HD enabled auto-merge March 2, 2024 07:43
@Zac-HD Zac-HD merged commit 3312a83 into HypothesisWorks:master Mar 2, 2024
95 checks passed
@roehling roehling deleted the 32bit branch March 3, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests/build/CI about testing or deployment *of* Hypothesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants