fix: support air_temperature with ccs2 #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* hyundai_kia_connect_api/KiaUvoApiEU.py:
jwillemsen
changed the title
cdnninja
requested changes
Feb 5, 2024
… this integration
* hyundai_kia_connect_api/KiaUvoApiEU.py:
cdnninja
reviewed
Feb 5, 2024
| @@ -406,7 +406,20 @@ def _update_vehicle_properties_ccs2(self, vehicle: Vehicle, state: dict) -> None | |||
|
|
|||
| vehicle.engine_is_running = get_child_value(state, "DrivingReady") | |||
|
|
|||
| # TODO: vehicle.air_temperature = get_child_value(state, "Cabin.HVAC.Driver.Temperature.Value") | |||
| if get_child_value(state, "Cabin.HVAC.Row1.Driver.Temperature.Value"): | |||
| tempIndex = get_hex_temp_into_index( | |||
There was a problem hiding this comment.
To confirm is your raw data in hex? I got the impression it wasn't. This is only needed for cars that don't show the decimal value.
There was a problem hiding this comment.
You are correct, it is decimal, just found also that when the car is off the value is set to "OFF"
* hyundai_kia_connect_api/KiaUvoApiEU.py:
cdnninja
requested changes
Feb 5, 2024
| # TODO: vehicle.air_temperature = get_child_value(state, "Cabin.HVAC.Driver.Temperature.Value") | ||
| air_temp = get_child_value( | ||
| state, | ||
| "Cabin.HVAC.Row1.Driver.Temperature.Value", |
There was a problem hiding this comment.
Looks like no unit set now.
There was a problem hiding this comment.
This is just the retrieval into a local variable, it is set on line 415 when it is not OFF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not tested, just looked at the json data as attached
kona2024data.txt