Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support air_temperature with ccs2 #496

Merged
merged 3 commits into from
Feb 5, 2024
Merged

fix: support air_temperature with ccs2 #496

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a2409f
Support air_temperature with ccs2
jwillemsen Feb 5, 2024
d9ab40f
Update air_temperature to match the same setup of the other places in…
jwillemsen Feb 5, 2024
d4fc1b1
Temp can also be OFF
jwillemsen Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hyundai_kia_connect_api/KiaUvoApiEU.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,13 @@ def _update_vehicle_properties_ccs2(self, vehicle: Vehicle, state: dict) -> None

vehicle.engine_is_running = get_child_value(state, "DrivingReady")

# TODO: vehicle.air_temperature = get_child_value(state, "Cabin.HVAC.Driver.Temperature.Value")
air_temp = get_child_value(
state,
"Cabin.HVAC.Row1.Driver.Temperature.Value",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no unit set now.

Copy link
Contributor Author

@jwillemsen jwillemsen Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the retrieval into a local variable, it is set on line 415 when it is not OFF

)

if air_temp != "OFF":
vehicle.air_temperature = (air_temp, TEMPERATURE_UNITS[1])

defrost_is_on = get_child_value(state, "Body.Windshield.Front.Defog.State")
if defrost_is_on in [0, 2]:
Expand Down