Adding Integration Tests to Person #916
Conversation
…ntact' into integration-test-organization-contact Merge remote-tracking branch 'origin/integration-test-organization-contact' into integration-test-organization-contact This merge incorporates changes from the remote repository into the local branch to synchronize our work with the latest updates.
|
@mozzy11 can you review this PR? |
sayed4900
changed the title
|
Also, link to a corresponding issue |
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertNull; |
There was a problem hiding this comment.
can we stick to one style for consistency? you are using both Assert class and static assertion methods
There was a problem hiding this comment.
Thanks for your review, I will edit it now.
| deletedPerson = personService.get(personId); | ||
| } catch (ObjectNotFoundException e) { | ||
|
|
||
| } |
There was a problem hiding this comment.
you're not doing anything with this catch,
catching ObjectNotFoundException
There was a problem hiding this comment.
you're not doing anything with this catch, catching
ObjectNotFoundException
can you check my last commit and give me feedback and thanks for your review.
should I open issue? |
…LIS-Global-2 into integration-tests-person
|
can you configure your IDE with java formatter to properly format your code ?? |
…LIS-Global-2 into integration-tests-person
|
I am trying to test function
can the problem comes from getPersonById Implementation ? |
|
@mozzy11 I adding more tests, can you review them? |
Yes @sayed4900 but it's always a good practice to open an issue before start working on it. |
Thanks @valens200 |
|
Hello @mozzy11 When I test this function it's always failed To resolve this issue, I modified the method to accept the personId parameter as a String directly, like so: query.setParameter("personId", personId). |
|
Thanks @sayed4900 . |
How can I solve the conflicts? |
|
👋 Hi, @sayed4900, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Add tests for updating and deleting a person