Update Credit.txt of MSX #1366
Update Credit.txt of MSX #1366
Conversation
|
What sprite did you add? We can maybe give credit directly for those sprites |
There were a full 33 PRs pertaining to MShock Modded: https://github.com/CleverRaven/Cataclysm-DDA/pulls?q=is%3Apr+mshock+author%3Achaosvolt That's kinda a lot to search through, and probably why listing prior tileset authors and major contributors in a single credit file seems to be the normal practice. |
|
Since you're here it would be very helpful if you could actually identify your contributions, it would allow for a nicer tracking of the credits. |
|
CV, we'd be more than happy to credit you. It is kind of the main reason we started this project. You don't need to dramatically complain in other communities about it, Fris0 is trying to help you get the same type of direct credit every other artist enjoys in the project, instead of a vague wave towards "I guess CV did some stuff but nobody knows what". It's meant to be respectful, not hostile. |
|
It would take a fair amount of sifting through the PRs to track all the sprites I'd added, then double-checking which ones are still present in the tileset. I'd figured that just updating the credit text was more than sufficient. |
|
It is, this isn't a question of sufficiency or asking you to "prove it", it is an offer of equality to other artists whose work have been added. |
|
If I can find time I can try to look through later on, thank you. |
|
The solution provided by #1368 obsoletes this PR. But the list of sprite you've made is still welcome and we'll add attribution on those sprites as soon as you provide it. Feel to PR it by puting the sprite in a folder named like the sprite and adding |
|
PR linked does not actually include the change this PR added. |
|
It links to the whole history of the tileset when it lived in the dda repo, therefor it does give credit to anyone that PRed something to that tileset at the time. |
|
It includes all the PRs you just linked, with your name and specific contributions. It's what we likely should have been doing in the first place as it gives much better credit information. |
|
Guess that works then. |
Summary
MSX "Update credit.txt of MSX"
Content of the change
Credits file of MSX was missing a contributor listed. Literally my first contribution to DDA was CleverRaven/Cataclysm-DDA#11707, which was when the Mshock set was developed into MShock Modded, which was used as the base by Xotto (source: https://discourse.cataclysmdda.org/t/20170216-big-sprite-update-mshock32xottoplus-tileset-oversprite-tileset/11301).
Testing
N/A
Additional information