Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update #2255

Merged
merged 11 commits into from
Dec 26, 2023
Merged

[Docs] update #2255

merged 11 commits into from
Dec 26, 2023

Conversation

vetall812
Copy link
Contributor

@vetall812 vetall812 commented Dec 22, 2023

Summary

Moved Ultica style guide into separate section
Added tools section
Fixed links style in various documents

Content of the change

Testing

check it here

Additional information

Should work with the rendered version too, but can't check before PR gets merged.

@Fris0uman
Copy link
Collaborator

The skin images in ultica style guide don't work, the doc should probably point to the sprites directly jnstead of using symlinks

@vetall812
Copy link
Contributor Author

vetall812 commented Dec 26, 2023

The skin images in ultica style guide don't work, the doc should probably point to the sprites directly jnstead of using symlinks

That's because pull requests have a separate link pattern. When merged symlinks start to work.
https://github.com/vetall812/CDDA-Tilesets/blob/docs_common_update/doc/style/UltimateCataclysm/image/skin-male.png

I can create a separate image file for skins. But previous docs version uses a symlins, so do I. I think we should keep symlinks for now. They are the good indicator if something changed in repository.

@vetall812
Copy link
Contributor Author

The skin images in ultica style guide don't work, the doc should probably point to the sprites directly jnstead of using symlinks

On the other hand they didn't work for old docs either. So probably separate images would be better. Let me sumbit them.

image

@Fris0uman Fris0uman merged commit da189d4 into I-am-Erk:master Dec 26, 2023
@vetall812 vetall812 deleted the docs_common_update branch December 26, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants