Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New split volume program #768

Draft
wants to merge 131 commits into
base: devel
Choose a base branch
from
Draft

New split volume program #768

wants to merge 131 commits into from

Conversation

oierlauzi
Copy link
Collaborator

Complete overhaul of the split volume program. A new graph theory-based approach was implemented to perform 3D classification

@oierlauzi
Copy link
Collaborator Author

I2PC/xmipp#859 needs to be merged first

@oierlauzi oierlauzi marked this pull request as ready for review January 24, 2024 14:01
Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is required...
There is no summary function to summarize the results
When you do the test, I will check the "viewer".

class XmippProtSplitVolume(ProtClassify3D, xmipp3.XmippProtocol):
OUTPUT_CLASSES_NAME = 'classes'
OUTPUT_VOLUMES_NAME = 'volumes'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment here become the help text. Please add it

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
1 Security Hotspot
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
11 Accepted issues

Measures
1 Security Hotspot
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

directionalClassificationMd = emlib.MetaData()
maskRow = emlib.metadata.Row()
directionRow = emlib.metadata.Row()
model = sklearn.mixture.GaussianMixture(

Check notice

Code scanning / SonarCloud

Results that depend on random number generation should be reproducible Low

Provide a seed for the random\_state parameter. See more on SonarCloud
@albertmena albertmena marked this pull request as draft May 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants