Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing SonarCloud issues: copy and assign operators, variable initialization, code simplification #424

Merged
merged 51 commits into from Dec 2, 2021
Merged

Fixing SonarCloud issues: copy and assign operators, variable initialization, code simplification #424

merged 51 commits into from Dec 2, 2021

Conversation

cossorzano
Copy link
Contributor

@cossorzano cossorzano commented Sep 24, 2021 •
edited

Ready now

@cossorzano
Removal of bug in Image_applyTransforMatScipion
b46d077
@cossorzano
Sonarcloud bug fix in lasso
c26f1f2
@cossorzano
Protection against going off bounds
05cee3f
@cossorzano
Copy constructor and assignment added to NaiveBayes
072e09d
@cossorzano
Matlab binding adapted to new metadata
06e2181
@cossorzano
Copy constructor and assignment added to EnsembleNaiveBayes
97fc27f
@cossorzano
Copy constructor and assignment added
0c9ecba
@cossorzano
Copy constructor and assignment added
049984b
@cossorzano
Default copy constructor of SOM removed
92b5354
@cossorzano
Empty constructor moved to header
d64a123
@cossorzano
Default copy constructors removed
106ffd0
@cossorzano
Copy constructor and assignment added
0fe7fe9
@cossorzano
Copy constructor and assignment added
384cf9a
@cossorzano
Avoid loops on double
cbf24c2
@cossorzano
Copy constructor added
6f389cb
@cossorzano
Removal of the default copy constructor of AlignmentAux
d4ff35f
@cossorzano
Some variables were not initialized
da2f798
@cossorzano
The array has 0 origin
4c6ac88
@cossorzano
Throw exception instead of exit
5fc7e79
@cossorzano
Throw exception instead of exit
c1c9542
@cossorzano
Do not use the default copy constructor
81eb4bb
@cossorzano
Incorrect comparison fixed
47497db
@cossorzano
Style improved
e60bc16
DStrelak
DStrelak requested changes Oct 19, 2021
View reviewed changes
src/xmipp/bindings/matlab/xmipp_nma_read_alignment.cpp Show resolved Hide resolved
src/xmipp/libraries/classification/naive_bayes.cpp Outdated Show resolved Hide resolved
src/xmipp/libraries/classification/naive_bayes.cpp Outdated Show resolved Hide resolved
src/xmipp/libraries/classification/pca.cpp Outdated Show resolved Hide resolved
src/xmipp/libraries/classification/svm_classifier.cpp Show resolved Hide resolved
src/xmipp/libraries/data/array_2D.h Outdated Show resolved Hide resolved
@DStrelak DStrelak changed the title Co warning hunt1 Fixing SonarCloud issues: copy and assign operators, variable initialization, code simplification Oct 19, 2021
@cossorzano
Copy link
Contributor Author

I think I did everything, I cannot see the requested changes left

@DStrelak
Copy link
Collaborator

Please resolve conflicts and sonar cloud issues first

@cossorzano cossorzano requested a review from Vilax October 29, 2021 13:22
@Vilax
Copy link
Collaborator

Vilax commented Oct 30, 2021

I think everything is correct, update the branch with devel to solve the conflicts

cossorzano and others added 3 commits November 5, 2021 10:05
@cossorzano
Compilation issue
bba9060
@albertmena
Merge branch 'devel' into co_WarningHunt1
aabcb7a 
# Conflicts:
#	src/xmipp/libraries/classification/svm.cpp
#	src/xmipp/libraries/reconstruction/flexible_alignment.cpp
@albertmena
xmipp_transformation:: (not added before on the merge 'devel' into cu…
cc294bb 
…rrent branch)
@albertmena
Copy link
Collaborator

I have merged devel into current branch to resolve the conflict on svm.cpp (deleted) and flexible_alignment.cpp. Could someone check the flexible_alignment.cpp file?

@DStrelak
Copy link
Collaborator

I have merged devel into current branch to resolve the conflict on svm.cpp (deleted) and flexible_alignment.cpp. Could someone check the flexible_alignment.cpp file?

flexible_alignment is currently broken, see #475 and related issue

@albertmena
Copy link
Collaborator

albertmena commented Nov 29, 2021 •
edited

I have merged devel into current branch to resolve the conflict on svm.cpp (deleted) and flexible_alignment.cpp. Could someone check the flexible_alignment.cpp file?

flexible_alignment is currently broken, see #475 and related issue

Ok thanks, I think the best option is wait until that PR is fixed and merged to devel, after that, we can merge devel into current branch (co_warningHunt1) again.

@albertmena
Merge branch 'devel' into co_WarningHunt1
8f4d6ea 
# Conflicts:
#	src/xmipp/libraries/reconstruction/flexible_alignment.cpp
albertmena
albertmena previously approved these changes Dec 1, 2021
View reviewed changes
@albertmena
Merge branch 'devel' into co_WarningHunt1
0fc3d68 
# Conflicts:
#	src/xmipp/libraries/reconstruction/flexible_alignment.cpp
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 78 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@albertmena
Copy link
Collaborator

In the future, we should avoid PRs with too many changes (too many commits, too many changed files).

@albertmena albertmena merged commit 8168104 into devel Dec 2, 2021
@cossorzano cossorzano deleted the co_WarningHunt1 branch April 29, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrelak DStrelak DStrelak requested changes

@albertmena albertmena albertmena approved these changes

@danielmarchan3 danielmarchan3 Awaiting requested review from danielmarchan3

@Vilax Vilax Awaiting requested review from Vilax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cossorzano @DStrelak @Vilax @albertmena