Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy Simplification for DataCategory and DataUse #62

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jun 30, 2022

Closes #58

Code Changes

  • rename provide.system to provide.service
  • move account to a subcategory of user
  • remove identifiable and non-identifiable subcategories
  • remove derived and provided subcategories
  • remove all account categories
  • clean up data_files/ These look really old if you look back in time, suggest updating or cleaning in a separate commit
  • update docs

Steps to Confirm

  • The default taxonomy loads properly with no orphans
  • This branch can be installed to fidesctl with known adjustments as part of upgrading to 1.1.0

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • Add address parent categories

Description Of Changes

There are some unknown updates left to be made in regard to description, name, and potential further relationship management (account vs contact)

Much conversation happened on the issue to get us to this point. Adding a note to the issue in fidesctl as well to point to these docs as the single source of truth going forward

@SteveDMurphy SteveDMurphy added this to the 1.1.0 milestone Jun 30, 2022
@SteveDMurphy SteveDMurphy self-assigned this Jun 30, 2022
@SteveDMurphy SteveDMurphy added the enhancement New feature or request label Jun 30, 2022
@SteveDMurphy
Copy link
Contributor Author

@ThomasLaPiana I still have quite a few documentation updates in here, just to confirm we want to sort of duplicate the docs in here and in fidesctl, correct? Or are we okay pointing the fidesctl docs to these?

@SteveDMurphy
Copy link
Contributor Author

Continuing to hold on docs changes until consensus reached in the issue, once we have that this should ship quickly along with the sibling issue in fidesctl

@ThomasLaPiana
Copy link
Contributor

looks like the changes were finally agreed upon @SteveDMurphy , taking a look now :)

@SteveDMurphy SteveDMurphy marked this pull request as ready for review July 8, 2022 16:48
@SteveDMurphy SteveDMurphy requested a review from a team July 8, 2022 16:48
@SteveDMurphy
Copy link
Contributor Author

Thanks @ThomasLaPiana !!! Just pushed them through and got the docs updates done as well. Re-validating in fidesctl now while awaiting a review

Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monstrous changes, but all LGTM!

@ThomasLaPiana
Copy link
Contributor

@SteveDMurphy it would be cool to generate all of those docs from the source code...I'm sure there's a way to do that, I'm going to open a ticket for it

@SteveDMurphy SteveDMurphy merged commit 0ded204 into main Jul 8, 2022
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-58-data-category-simplifications branch July 8, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataUse & DataCategory Simplifications
3 participants