Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp bugfix for helperbounds not handling ref data correctly #18

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

giannou
Copy link
Collaborator

@giannou giannou commented Jul 6, 2023

checkMin and checkMax tests have been wrong all this time due to this line:

x$ref <- cfg[[type]][x$variable]

Here's a suggested quickfix.

@giannou giannou requested a review from tscheypidi July 6, 2023 07:13
@giannou giannou merged commit ff2706e into IAMconsortium:master Jul 6, 2023
1 check failed
@giannou
Copy link
Collaborator Author

giannou commented Jul 6, 2023

Thanks, merging now. Since the package is not part of pik-piam, I'm not sure how building and publishing the corrected version on the PIK-CRAN will work.

@tscheypidi
Copy link
Member

@giannou Oh, good point. It is actually the same procedure as for packages on pik-piam. But that also means that you have to run buildLibrary to increase the version number and have the update automatically distributed via PIK-CRAN. Can you create another PR after running buildLibrary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants