Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hierarchy Filter (first pull request) #226

Merged
merged 23 commits into from
Mar 15, 2023
Merged

Hierarchy Filter (first pull request) #226

merged 23 commits into from
Mar 15, 2023

Commits on Feb 28, 2023

  1. First Commit with Hierarchy Filter

    @GretchenSchowalter
    GretchenSchowalter committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    c9a8bc4 View commit details
    Browse the repository at this point in the history

  2. updated codelist.py to include hierarchy filter

    @GretchenSchowalter
    GretchenSchowalter committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    65b284e View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Commiting the hierarchy filter with docstrings

    @GretchenSchowalter
    GretchenSchowalter committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    5876b2b View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Hierarchy filter now returns RegionCodeList instance 

    The hierarchy filter now returns an instance of the RegionCodeList
    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    8a5d962 View commit details
    Browse the repository at this point in the history

  2. Update codelist.py

    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    792c8a8 View commit details
    Browse the repository at this point in the history

  3. Fixing extra whitespaces and lengthy ValueError message.

    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    36d16af View commit details
    Browse the repository at this point in the history

  4. Editing to add whitespaces 

    Fixing errors with Stickler
    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    92633f9 View commit details
    Browse the repository at this point in the history

  5. Update nomenclature/codelist.py 

    Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
    @GretchenSchowalter @danielhuppmann
    GretchenSchowalter and danielhuppmann committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    209a5f0 View commit details
    Browse the repository at this point in the history

  6. Update nomenclature/codelist.py 

    changing name from "hierarchy_filter" to "filter"

Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
    @GretchenSchowalter @danielhuppmann
    GretchenSchowalter and danielhuppmann committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    e0d6b34 View commit details
    Browse the repository at this point in the history

  7. changed call to just "filter" 

    changed the "hierarchy_filter()" to just "filter()"
    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    d6734c8 View commit details
    Browse the repository at this point in the history

  8. Removing extra whitespaces (stickler)

    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    4839eea View commit details
    Browse the repository at this point in the history

  9. Removed period at the end of match string in the filter value error test

    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    dd52a98 View commit details
    Browse the repository at this point in the history

  10. Update nomenclature/codelist.py 

    Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
    @GretchenSchowalter @phackstock
    GretchenSchowalter and phackstock committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    36031e3 View commit details
    Browse the repository at this point in the history

  11. Update nomenclature/codelist.py 

    Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
    @GretchenSchowalter @phackstock
    GretchenSchowalter and phackstock committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    ec15039 View commit details
    Browse the repository at this point in the history

  12. adding list of available filter hierarchy options 

    adding list of available filter hierarchy options to the value error, and changing the name of the new RegionCodeList instance to self.name (name of the original RegionCodeList getting filtered).
    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c1fcb01 View commit details
    Browse the repository at this point in the history

  13. Updating to reflect the name change in codelist.py

    @GretchenSchowalter
    GretchenSchowalter committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    8c56c6b View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Updated ValueError to include available options

    @GretchenSchowalter
    GretchenSchowalter committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    234928e View commit details
    Browse the repository at this point in the history

  2. fixing conflicts updating test and codelist

    @GretchenSchowalter
    GretchenSchowalter committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    da7eb0f View commit details
    Browse the repository at this point in the history

  3. update files to match flake8/black standards

    @GretchenSchowalter
    GretchenSchowalter committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    8fee65b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Adding RegionCodeList and VariableCodeList to codelist.rst

    @GretchenSchowalter
    GretchenSchowalter committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8d0c2c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Added line of space in codelist.py

    @GretchenSchowalter
    GretchenSchowalter committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4dd2d1a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Made error message simpler, and added def hierarchy(self) placeholder

    @GretchenSchowalter
    GretchenSchowalter committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    1006b3d View commit details
    Browse the repository at this point in the history

  2. Made hierarchy method a property and added a test

    @GretchenSchowalter
    GretchenSchowalter committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    614e30b View commit details
    Browse the repository at this point in the history