Allow ISO3 codes as string #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phackstock
reviewed
May 24, 2023
danielhuppmann
force-pushed
the
feature/iso3-as-str
branch
from
2465fdb
to
abb774e
Compare
phackstock
approved these changes
May 25, 2023
|
Thanks @phackstock! |
GretchenSchowalter
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to implement ISO3 codes for the ECEMF/openENTRANCE project, I realized that the list was overly complicated for a list of countries. So this PR extends the "iso3_codes" attribute to be provided as a string. It also makes the error message slightly more readable by un-listing...