Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify docs folder structure, move to Black GitHub Actions #256

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jun 5, 2023

Two small clean-ups because Stickler terminated its service and to keep consistency with the pyam package.

@danielhuppmann danielhuppmann self-assigned this Jun 5, 2023
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor comments

build:
pytest:
strategy:
matrix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a matrix for a single OS version with a single python version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified.


:end
popd
REM This file was generated with sphinx-quickstart version 3.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need this file? From what I understand .bat files are for use on Windows and I don't think anyone is building the docs on Windows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it as long as there is no effort required to maintain it...

@danielhuppmann danielhuppmann merged commit 9ca6903 into main Jun 26, 2023
12 checks passed
@danielhuppmann danielhuppmann deleted the devops/docs-stickler branch June 26, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants