Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test cases to illustrate potentially conflicting information #315

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add failing test cases to illustrate potentially conflicting information #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/data/region_processing/overlapping_instructions/m_a.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
model: m_a
native_regions: [region_A, region_B]
common_regions:
- region_C: [region_A, region_B]
63 changes: 63 additions & 0 deletions tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,3 +483,66 @@ def test_region_aggregation_unknown_region(simple_df, simple_definition, caplog)
text in caplog.text
for text in ["not defined in the 'region' codelist", "unknown region"]
)


def test_region_aggregation_overlapping_instructions_case_1():
# region-aggregation variable is provided
res = RegionProcessor.from_directory(
TEST_DATA_DIR / "region_processing" / "overlapping_instructions",
DataStructureDefinition(TEST_DATA_DIR / "region_processing" / "dsd"),
).apply(
IamDataFrame(
pd.DataFrame(
[
["m_a", "s_a", "region_A", "Variable A", "EJ/yr", 1],
["m_a", "s_a", "region_B", "Variable A", "EJ/yr", 1],
["m_a", "s_a", "region_A", "Variable A (max)", "EJ/yr", 1],
["m_a", "s_a", "region_B", "Variable A (max)", "EJ/yr", 1],
],
columns=IAMC_IDX + [2020],
)
)
)
assert False


def test_region_aggregation_overlapping_instructions_case_2():
# region-aggregation variable is provided at base and aggregation level for
# aggregation region -> takes priority
res = RegionProcessor.from_directory(
TEST_DATA_DIR / "region_processing" / "overlapping_instructions",
DataStructureDefinition(TEST_DATA_DIR / "region_processing" / "dsd"),
).apply(
IamDataFrame(
pd.DataFrame(
[
["m_a", "s_a", "region_A", "Variable A", "EJ/yr", 1],
["m_a", "s_a", "region_B", "Variable A", "EJ/yr", 1],
["m_a", "s_a", "region_C", "Variable A (max)", "EJ/yr", 2],
],
columns=IAMC_IDX + [2020],
)
)
)
print(res.data)
assert False


def test_region_aggregation_overlapping_instructions_case_3():
# only base variable is provided -> all good
res = RegionProcessor.from_directory(
TEST_DATA_DIR / "region_processing" / "overlapping_instructions",
DataStructureDefinition(TEST_DATA_DIR / "region_processing" / "dsd"),
).apply(
IamDataFrame(
pd.DataFrame(
[
["m_a", "s_a", "region_A", "Variable A", "EJ/yr", 1],
["m_a", "s_a", "region_B", "Variable A", "EJ/yr", 2],
],
columns=IAMC_IDX + [2020],
)
)
)
print(res.data)
assert False
Loading