Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow external repo double stacking #324

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Disallow external repo double stacking #324

merged 5 commits into from
Feb 9, 2024

Conversation

phackstock
Copy link
Contributor

Closes #316.

This PR implements a check that an external repo does not reference another external repo, thus safeguarding against external repo double stacking.

@phackstock phackstock added the enhancement New feature or request label Feb 9, 2024
@phackstock phackstock self-assigned this Feb 9, 2024
danielhuppmann
danielhuppmann approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just one minor suggestion on the error message

nomenclature/config.py Outdated Show resolved Hide resolved
@phackstock phackstock merged commit 1a2c2ed into IAMconsortium:main Feb 9, 2024
8 checks passed
@phackstock phackstock deleted the feature/no-external-repo-double-stacking branch February 9, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

Assignees

@phackstock phackstock

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double stacking external repos does not work as expected
2 participants
@phackstock @danielhuppmann