Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3.12 #339

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Conversation

phackstock
Copy link
Contributor

@phackstock phackstock commented Mar 21, 2024

Looks like the nomenclature python3.12 upgrade is working fine.

@phackstock phackstock self-assigned this Mar 21, 2024
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few nitpicky suggestions inline, good to merged either way

@@ -5,7 +5,7 @@
Installation
============

.. attention:: The nomenclature requires python >= 3.8
.. attention:: The nomenclature requires python >= 3.10, < 3.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t we remove this warning entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point.

docs/index.rst Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@phackstock phackstock merged commit aec48d7 into IAMconsortium:main Mar 21, 2024
11 checks passed
@phackstock phackstock deleted the feature/python3.12 branch March 21, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants