-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python3.12 #339
Add python3.12 #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few nitpicky suggestions inline, good to merged either way
docs/installation.rst
Outdated
@@ -5,7 +5,7 @@ | |||
Installation | |||
============ | |||
|
|||
.. attention:: The nomenclature requires python >= 3.8 | |||
.. attention:: The nomenclature requires python >= 3.10, < 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t we remove this warning entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point.
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Looks like the nomenclature python3.12 upgrade is working fine.