New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DataStructureDefinition
dimensions customizable
#45
Make DataStructureDefinition
dimensions customizable
#45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following files do not match the black
styleguide:
- nomenclature/codes.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, really cool addition with the generic schema that you can optionally validate against.
Just some minor comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, ready to merge.
This PR allows to specify "custom" (aka generic) CodeList dimensions for a
DataStructureDefinition
. This can be used to validate against an IamDataFrame against a list of valid "scenario" names or (if it exists) a list of "subannual" categorical timeslices.As a side bonus, the PR also closes #16.