Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DataStructureDefinition dimensions customizable #45

Merged

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Nov 15, 2021

This PR allows to specify "custom" (aka generic) CodeList dimensions for a DataStructureDefinition. This can be used to validate against an IamDataFrame against a list of valid "scenario" names or (if it exists) a list of "subannual" categorical timeslices.

As a side bonus, the PR also closes #16.

Copy link
Contributor

@stickler-ci stickler-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files do not match the black styleguide:

  • nomenclature/codes.py

Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, really cool addition with the generic schema that you can optionally validate against.
Just some minor comments below.

nomenclature/core.py Outdated Show resolved Hide resolved
nomenclature/core.py Outdated Show resolved Hide resolved
nomenclature/core.py Outdated Show resolved Hide resolved
nomenclature/validation.py Show resolved Hide resolved
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ready to merge.

@danielhuppmann danielhuppmann merged commit ef52aa2 into IAMconsortium:main Nov 15, 2021
@danielhuppmann danielhuppmann deleted the feature/extra-codelist branch November 25, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten file attribute in codelists
2 participants