-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decide if/how to fill in missing columns in constructor #208
Comments
Tricky one, I'm not sure. I've tried doing auto-filling using |
I agree that all required columns other than Need to check whether the „check for duplicates“ part at the end of |
Update following comment by @znicholls: If pandas behaves weird with |
One more thought about |
hmmm ok so maybe |
This issue has been resolved in the sense that the constructor now takes keyword arguments with a default value for columns that are not in the input dataframe as suggested above:
|
During PR #199 we had a use case that became unsupported in the final implementation, notably filling in "missing" values in expected columns
For example, a dataframe looking like
At the moment raises an error:
At some point in the PR, default values would be filled in for these three columns (just with their column names) for ease of use. In many cases, I find that I don't actually care what these values are, and in fact just want the mountain of other nice
pyam
utilities to work with my data.So the question is: should we force users to fill in these, e.g.,
or should we do that for them with column names or some other value?
The text was updated successfully, but these errors were encountered: