add ability to fill between lines #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 15, 2018
pyam/plotting.py
Outdated
| @@ -640,6 +646,9 @@ def line_plot(df, x='year', y='value', ax=None, legend=None, title=True, | |||
| props = assign_style_props(df, color=color, marker=marker, | |||
| linestyle=linestyle, cmap=cmap) | |||
|
|
|||
| if fill_between and not 'color' in props: | |||
There was a problem hiding this comment.
E713 test for membership should be 'not in'
stickler-ci
reviewed
Oct 15, 2018
pyam/plotting.py
Outdated
| dictionary, those arguments will be provided instead of defaults. | ||
| default: None | ||
| final_ranges : boolean or dict, optional | ||
| Add vertical line between minima/maxima of the 'color' argument in the |
|
This is good to go pending CI, @danielhuppmann |
|
ok, now actually g2g @danielhuppmann |
|
hold on this, testing with the SR1.5 dataset |
|
Ok, found some other issues which are now fixed and tested. Finally ready, @danielhuppmann |
|
what can I say other than - amazing! |
danielhuppmann
requested changes
Oct 17, 2018
tests/test_plotting.py
Outdated
| newdata = ['test_model1', 'test_scenario1', 'World', 'Primary Energy|Coal', | ||
| 'EJ/y', 2015, 3.50] | ||
| df.data.loc[len(df.data) + 1] = newdata | ||
| print(df.data) |
|
apology accepted - very glad that this doesn't only happens to me... |
danielhuppmann
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
Please describe the changes introduced by this PR.