Fix scatter() to work with nan in meta columns
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidden
reviewed
Feb 5, 2019
| .reset_index() | ||
| ) | ||
| else: | ||
| return self.data.copy() | ||
|
|
||
| def _discover_meta_cols(self, **kwargs): |
There was a problem hiding this comment.
even thought its private, could you please add a docstring explaining what this function does?
There was a problem hiding this comment.
Sorry to be pedantic, but maybe something like:
Return the subset of `kwargs` values (not keys!) which match a metadata column name
gidden
reviewed
Feb 5, 2019
|
one last request, then g2g! |
|
thanks @danielhuppmann ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description of PR
This PR extends the fix for the
line_plot()feature withnanin meta columns (see #187) to thescatterfunction.