add test for require_variable() #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tests the behaviour of using a list of years as argument - updates the docstring
stickler-ci
reviewed
Mar 6, 2020
stickler-ci
reviewed
Mar 6, 2020
Co-Authored-By: Daniel Huppmann <dh@dergelbesalon.at>
Co-Authored-By: Daniel Huppmann <dh@dergelbesalon.at>
Co-Authored-By: Daniel Huppmann <dh@dergelbesalon.at>
danielhuppmann
approved these changes
Mar 7, 2020
There was a problem hiding this comment.
thanks @jkikstra for improving the docs and adding a test!
food for thought - if you think that requiring a variable to exist for ALL years is a frequent use case, we might want to add a method=['any', 'all'] kwarg to the function in a next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
tests the behaviour of using a list of years as an argument for
require_variable()clarifies the docstring about the expected behaviour
Tests Added
Documentation Added