Show head of duplicate rows in error message #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zikolach
approved these changes
May 11, 2020
stickler-ci
reviewed
May 11, 2020
|
|
||
| if df.empty: | ||
| logger.warning('Formatted data is empty!') | ||
|
|
||
| return sort_data(df, idx_cols), time_col, extra_cols | ||
|
|
||
| def _raise_data_error(msg, data): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
|
re @zikolach
I think that this is due to a timeout for the IIASA server - the pyam tests are always a bit fickle since we have tests against the rest-api. Usually restarting the build on travis is enough. But that is one more reason why I wanted to run the tests against an integration-test instance rather than the iamc15 instance, hoping this would give faster response time. |
|
Thanks @danielhuppmann ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Documentation AddedDescription of PR
Initializing an IamDataFrame with duplicate rows already raised an error. This PR extends the error message to include the head of the duplicate rows.
This came up as part of @zikolach and @vruijven working on the ixmp-server-integration pipeline and will hopefully simplify identifying the source of problematic data uploads.