New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importing ABC from collections in Python 3. #393
Conversation
thanks @tirkarthi for this fix! I actually started on something similar, see danielhuppmann@c4c8f19 - is there any specific reason for preferring |
ABC can be imported from collections only in Python. In Python 3 collections.abc is recommended. Using six would ensure it works on both python 2 and 3. I assumed Python 2 is supported by the project. If not then directly using collections.abc is a simple solution. Does the project support Python 2? |
Thanks! I believe that all major packages are dropping support for python 2, and we started using |
Thanks, I will modify the PR |
@danielhuppmann I have force pushed my changes to ensure collections.abc is used instead of six. |
Thanks @tirkarthi! Can you still add a line to the release notes? Note that this is the first PR since the last release, so you'll need to insert it between |
Thanks, resolved the merge conflict for you! |
Sorry, I didn't notice and force pushed my change resolving the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tirkarthi for this nice improvement!
Thanks @danielhuppmann for the review and merge :) |
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
Fixes #377 . It also fixes several more instances in addition to the one reported in #377