New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature to pass an explicit weight dataframe to downscale_region()
#411
Add a feature to pass an explicit weight dataframe to downscale_region()
#411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 93.26% 93.33% +0.06%
==========================================
Files 35 35
Lines 4129 4169 +40
==========================================
+ Hits 3851 3891 +40
Misses 278 278
Continue to review full report at Codecov.
|
@fabiosferra, maybe also of interest to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Based on the tests we've done the feature works as intended.
Tested the new features locally and everything seems to be working as intended. Looking forward to add to this (= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
on the risk of appearing meticulous: passing the default values of optional arguments is not 100% consistent in the doc string (e.g. region lost "World")... but I see that is also the case for other docstrings and not really of importance.... but I had to find something (=
Thanks @l-welder for the review and noticing the change in the docs. We actually started out specifying the default in the docstrings, but (if I recall correctly) @khaeru pointed out that the NumPy-style docstrings convention is to just write "optional", because the default value is anyway obvious from the function signature. So I'm changing this whenever I stumble over the legacy docstrings... |
Please confirm that this PR has done the following:
Description of PR
This PR adds an option to pass an explicit weight-dataframe with region (and possibly others) as index dimension and the time domain as columns. Implementation based on many discussions with @maartenbrinkering on his specific use case.