New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include meta
in new IamDataFrames returned by aggregation functions
#416
Include meta
in new IamDataFrames returned by aggregation functions
#416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 93.43% 93.45% +0.02%
==========================================
Files 35 35
Lines 4189 4220 +31
==========================================
+ Hits 3914 3944 +30
- Misses 275 276 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine. The one thing I couldn't see was an explicit test for the behaviour you've changed? Maybe I just missed it though.
Thanks for the review @znicholls
The new behavior is tested by adding meta-columns in the test dataframes provided in Anyway, I added an explicit test for |
Please confirm that this PR has done the following:
Description of PR
This PR ensures that all aggregation functions include the
meta
table of the original IamDataFrame when returning a new instance (append=False
). As part of the implementation, all test dataframes now have one or two meta column, and the merging of meta tables was moved from theappend()
function to an own function in utils to be reused.