Fix return type of validation after data refactoring #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Sep 28, 2020
danielhuppmann
force-pushed
the
fix/validate-return
branch
from
411f66e
to
3757a77
Compare
stickler-ci
reviewed
Sep 28, 2020
danielhuppmann
added
the
data back-end
|
will likely test this on Monday/Tuesday as will run soem vetting scripts then |
|
merging to collect clean-up PRs before the next release, please start a new issue referencing this and #428 if problems are not solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description of PR
This PR reverts the behavior of the
validate()function to the status before the refactoring of the data-backend.pandas.DataFrameReturnssection to the docstringcloses #428