Enable `Path` as arg #458

danielhuppmann · 2020-11-17T06:13:23Z

Please confirm that this PR has done the following:

This PR was initiated by a comment by @znicholls (#454 (comment)) about using tmpdir facility in the tests.

Changes:

enable initializing an IamDataFrame with a Path or LocalPath object (in addition to passing a file path as string)
raise a dedicated error message when initializing without meaningful args 'IamDataFrame constructor not properly called!' rather than showing the message Initializing from list is not supported, ... (which was previously shown in that case)
rework the initialization workflow and add more comments
use tmpdir facility in the io-tests

znicholls

lgtm

pyam/utils.py

danielhuppmann added 3 commits November 16, 2020 22:00

use tmpdir fixture and Path in io-tests

b176b6e

move error message for initializing from list to core.py

b8e3103

rework the casting workflow

b3e2861

danielhuppmann added the enhancement label Nov 17, 2020

danielhuppmann requested a review from znicholls November 17, 2020 06:13

danielhuppmann self-assigned this Nov 17, 2020

znicholls approved these changes Nov 17, 2020

View reviewed changes

pyam/utils.py Outdated Show resolved Hide resolved

danielhuppmann added 5 commits November 17, 2020 16:49

put listable-error into correct place

ea6f089

simplify read_pandas (make path as str illegal)

e4554b6

update map_regions() function

4448433

make meta an explicit kwarg of the IamDataFrame initialization

4b1b7b4

rewrite the IamDataFrame initialization docs

7d3402f

danielhuppmann marked this pull request as ready for review November 18, 2020 05:52

Add to release notes

4c9f6ed

danielhuppmann merged commit b23f76d into IAMconsortium:master Nov 18, 2020

danielhuppmann deleted the io/path branch November 18, 2020 08:15