Add a nightly test #477
Merged
Add a nightly test #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! @danielhuppmann any reason to execute it every night instead of Tuesdays only? |
Just wanted to reduce the number of annoying emails sent to maintainers... Once a week seems like a reasonable compromise. |
|
Won't block for that. But you get emails on successful tests?
…On Tue, Jan 5, 2021, 20:55 Daniel Huppmann ***@***.***> wrote:
any reason to execute it every night instead of Tuesdays only?
Just wanted to reduce the number of annoying emails sent to maintainers...
Once a week seems like a reasonable compromise.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#477 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKUAELHPB54PE2CPPJKB53SYNVD3ANCNFSM4VUNYZVQ>
.
|
|
Not on successful tests... But I assume that we won't fix emerging issues on a daily basis, and I don't want to receive a daily reminder that some pandas update broke the package - for weeks. |
danielhuppmann
force-pushed
the
devops/nightly
branch
from
53a2979
to
7ac7cac
Compare
|
Thanks @danielhuppmann ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR adds a nightly test (actually executed once a week Tuesday morning in the current configuration) as a safeguard and warning against errors arising from dependency API changes.
I tested it by setting
devops/nightlyas the default branch on my fork, forked from an outdated version that I knew to have dependency conflicts with the latest pandas release. The test ran and failed as expected this morning.