Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reading non-default scenario versions from IIASA API #486

Merged

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jan 22, 2021

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR uses the "custom-index" feature (currently in beta support, see #481) to read data of non-default scenario versions from the IIASA RestAPI and return an IamDataFrame with a non-standard index.

@danielhuppmann danielhuppmann added iiasa-api generic-index-cols Issues related to non-standard index columns labels Jan 22, 2021
@danielhuppmann danielhuppmann self-assigned this Jan 22, 2021
tests/test_iiasa.py Outdated Show resolved Hide resolved
@danielhuppmann danielhuppmann marked this pull request as ready for review January 22, 2021 09:22
@danielhuppmann
Copy link
Member Author

danielhuppmann commented Jan 22, 2021

@fbenke-pik, you may like this new feature... Try pyam.read_iiasa(<instance>, default=False) to get not just the latest version of a model-scenario but all of versions uploaded to the IIASA database...

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #486 (698b7af) into master (3d31fdd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   92.96%   92.99%   +0.03%     
==========================================
  Files          41       41              
  Lines        4746     4756      +10     
==========================================
+ Hits         4412     4423      +11     
+ Misses        334      333       -1     
Impacted Files Coverage Δ
pyam/iiasa.py 89.18% <100.00%> (+0.30%) ⬆️
tests/test_iiasa.py 92.80% <100.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d31fdd...698b7af. Read the comment docs.

@danielhuppmann
Copy link
Member Author

Merging as there were no critical comments or objections...

@danielhuppmann danielhuppmann merged commit 1a2910b into IAMconsortium:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generic-index-cols Issues related to non-standard index columns iiasa-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants