Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable loading meta from csv #496

Merged
merged 5 commits into from Feb 8, 2021

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Feb 8, 2021

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR enables reading a meta dataframe from a csv file (and adds a test for it).

closes #495

@danielhuppmann danielhuppmann self-assigned this Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #496 (00d03f6) into master (76c33a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   92.96%   92.97%   +0.01%     
==========================================
  Files          41       41              
  Lines        4747     4755       +8     
==========================================
+ Hits         4413     4421       +8     
  Misses        334      334              
Impacted Files Coverage Δ
pyam/core.py 92.32% <100.00%> (+<0.01%) ⬆️
tests/test_io.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c33a5...ed87e16. Read the comment docs.

@danielhuppmann danielhuppmann marked this pull request as ready for review February 8, 2021 12:34
@danielhuppmann
Copy link
Member Author

pinging @coroa for a review

Copy link
Collaborator

@coroa coroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I was not aware of the possibility to pass in an pd.ExcelFile, that explains the previous code change.

@danielhuppmann danielhuppmann merged commit 526f6c1 into IAMconsortium:master Feb 8, 2021
@danielhuppmann danielhuppmann deleted the io/meta-csv branch February 8, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: IamDataFrame.load_meta with csv filename string broken
2 participants