Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for non-empty invisible header in 'meta' sheet #508

Merged
merged 3 commits into from Mar 18, 2021

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Mar 16, 2021

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added ->bugfix, no functional change
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR resolves an unexpected error reported by @fbenke-pik when initializing an IamDataFrame from an xlsx file where the meta sheet has only a header row and also a has non-empty but invisible entry in that header row. (yes, this is a corner case)

@danielhuppmann danielhuppmann self-assigned this Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #508 (4b9681e) into main (956d1d6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #508   +/-   ##
=====================================
  Coverage   93.0%   93.0%           
=====================================
  Files         43      43           
  Lines       4867    4876    +9     
=====================================
+ Hits        4528    4537    +9     
  Misses       339     339           
Impacted Files Coverage Δ
pyam/utils.py 91.9% <100.0%> (+0.1%) ⬆️
tests/test_io.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956d1d6...4b9681e. Read the comment docs.

Copy link
Collaborator

@fbenke-pik fbenke-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@danielhuppmann
Copy link
Member Author

Resolving data import corner cases one PR at a time... 😜

@danielhuppmann danielhuppmann merged commit a9e93e0 into IAMconsortium:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants