Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set defaults in binary operations #538

Merged
merged 7 commits into from May 31, 2021

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented May 27, 2021

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR adds a keyword argument to set default values in the binary operations if either a or b (or any keyword argument for apply()) are not defined. This can be used either as fillna=5 or fillna=dict(a=5}.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #538 (7ea19cc) into main (87ed604) will increase coverage by 0.0%.
The diff coverage is 97.2%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #538   +/-   ##
=====================================
  Coverage   93.5%   93.5%           
=====================================
  Files         47      47           
  Lines       5129    5167   +38     
=====================================
+ Hits        4796    4832   +36     
- Misses       333     335    +2     
Impacted Files Coverage Δ
pyam/_ops.py 96.0% <93.7%> (-4.0%) ⬇️
pyam/core.py 92.6% <100.0%> (ø)
tests/test_ops.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ed604...7ea19cc. Read the comment docs.

@danielhuppmann danielhuppmann marked this pull request as ready for review May 27, 2021 05:19
@danielhuppmann
Copy link
Member Author

danielhuppmann commented May 31, 2021

Merging as announced via the Slack channel (unfortunately, no volunteers for a review)

@danielhuppmann danielhuppmann merged commit a4c6c71 into IAMconsortium:main May 31, 2021
@danielhuppmann danielhuppmann deleted the ops/default branch May 31, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant