-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all missing rows for require_data()
#772
Show all missing rows for require_data()
#772
Conversation
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
=======================================
- Coverage 94.4% 94.4% -0.1%
=======================================
Files 62 62
Lines 6130 6132 +2
=======================================
Hits 5789 5789
- Misses 341 343 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment other than that looks good to me.
I've tried to wrap my head around require_data
in its entirety but wasn't quite able to. As long as it's working though that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, that should help a lot in finding missing data 👍.
Good to merge from my side.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR changes the returned dataframe of the
require_data()
method to not only show the failing scenarios (dataframe of model-scenario combinations), but a dataframe that has all missing combinations of elements.So if model_a - scen_a does not have the variableEmissions|CO2 at the global level, the method will return the following:
closes #768