Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop six as dependency #846

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

mathause
Copy link
Contributor

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

As you require python 3+ you can drop the dependency on six (I think the poetry.lock file does not need any updates, but let me know if it does). I can add AUTHORS.rst and RELEASE_NOTES.md if you want to go ahead with this change.

@mathause
Copy link
Contributor Author

The changes to poetry.lock are unrelated but seems necessary to update it anyways.

@mathause
Copy link
Contributor Author

Test failure are unrelated.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.0%. Comparing base (ddbb88e) to head (6ab9404).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #846     +/-   ##
=======================================
- Coverage   95.0%   95.0%   -0.1%     
=======================================
  Files         64      63      -1     
  Lines       6134    6148     +14     
=======================================
+ Hits        5828    5841     +13     
- Misses       306     307      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mathause!

@danielhuppmann danielhuppmann merged commit 8f3e071 into IAMconsortium:main Apr 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants