Panel label #90
Merged
Panel label #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidden
reviewed
Sep 17, 2018
pyam/plotting.py
Outdated
| The column to use for y-axis values | ||
| default: value | ||
| """ | ||
| if ax is not None: |
There was a problem hiding this comment.
suggest moving the _lim_loc function up inside here if this is the only place we use it
|
failure could be because of the freetype version, but not sure. |
|
I think that failure is due to wrong matplotlib version (2.1.2 on CI, 2.2.2 locally for generating the test figure) - but 2.1.2 doesn't run on Mac for some framework problem. @gidden, can you generate the test figure and PR into my branch? |
|
done |
gidden
reviewed
Sep 17, 2018
tests/test_plotting.py
Outdated
| @@ -388,3 +388,11 @@ def test_stack_plot_other(plot_df): | |||
| .stack_plot(ax=ax, stack='scenario', cmap='viridis', title='foo') | |||
| ) | |||
| return fig | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(IS_WINDOWS, reason=WINDOWS_REASON) | |||
There was a problem hiding this comment.
this needs to be deleted now. apologies, I was thrashing in CI and removed this from other functions.
|
one final bit, then g2g |
|
good to go, @gidden! |
|
now with release notes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description
This PR adds a function to the plotting library to set a "panel label", which is by default placed in the top-left corner of an Axes object.