initialise IamDataFrame with index #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this good to go? |
gidden
reviewed
Sep 20, 2018
| @@ -169,6 +169,10 @@ def format_data(df): | |||
| df['scenario'] = scen.apply( | |||
| lambda s: '-'.join(s.split('-')[1:]).strip()) | |||
|
|
|||
| # reset the index if meaningful entries are included there | |||
| if not list(df.index.names) == [None]: | |||
There was a problem hiding this comment.
here I think you could do just if df.index.names:
There was a problem hiding this comment.
just tried this, seems that this returns True even if no names are given
danielhuppmann
force-pushed
the
init_with_index
branch
from
8e4b75c
to
d45b870
Compare
|
thanks @gidden, good to go after the tests pass! |
|
Ah, of course, it has an element. Oh well.
…On Thu, Sep 20, 2018 at 5:10 PM Daniel Huppmann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pyam/utils.py
<#93 (comment)>:
> @@ -169,6 +169,10 @@ def format_data(df):
df['scenario'] = scen.apply(
lambda s: '-'.join(s.split('-')[1:]).strip())
+ # reset the index if meaningful entries are included there
+ if not list(df.index.names) == [None]:
just tried this, seems that this returns True even if no names are given
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#93 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABVAEZ4uwS_aoYq_AxF9Q66I9ZjHq0nzks5uc6_4gaJpZM4Wulxe>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description of PR
This PR extends the IamDataFrame constructor to take a pd.DataFrame with a meaningful index, for example the dataframe returned by
IamDataFrame.timeseries(). Closes #77