Quickfix for pint v0.20 (whitespace not allowed in alias) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 73.10% 73.10%
=======================================
Files 4 4
Lines 145 145
=======================================
Hits 106 106
Misses 39 39 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
khaeru
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Thanks!
Unfortunately pint development is kind of opaque—no notes in the change log or migration hints for this particular change, so we're left to inspect the commit history to guess what's new 🤷🏾♂️
That could reveal a different way to adjust our definitions, but for now this is a fine mitigation to keep iam-units usable. I'll merge and then release sometime today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove whitespaces in alias-definitions in line with stricter rules introduced in pint v0.20.
Closes #40