Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CMake option TESTS #30

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Mar 12, 2019

Cf. #28.

Shall we adapt the build flags before making the first release? Cf. #15.

CMakeLists.txt Show resolved Hide resolved
@ranocha
Copy link
Member Author

ranocha commented Mar 14, 2019

I don't understand why the linux build on Appveyor fails. There seem to be problems with the MSR registers that haven't been there before (https://ci.appveyor.com/project/ranocha/toolkiticl/builds/23065483/job/30jget4xg01si9pg#L2212).

@ranocha
Copy link
Member Author

ranocha commented Mar 14, 2019

For the failed build on Linux, clinfo reports a slightly different CPU: Intel(R) Xeon(R) CPU @ 2.30GHz (failed) instead of Intel(R) Xeon(R) CPU E5-2697 v3 @ 2.60GHz (pass).

@ranocha ranocha mentioned this pull request Mar 14, 2019
5 tasks
@ranocha
Copy link
Member Author

ranocha commented Mar 14, 2019

Maybe reading MSR is simply not reliable on virtual platforms. I'll disable that test.

@philipheinisch
Copy link
Member

For the failed build on Linux, clinfo reports a slightly different CPU: Intel(R) Xeon(R) CPU @ 2.30GHz (failed) instead of Intel(R) Xeon(R) CPU E5-2697 v3 @ 2.60GHz (pass).

In virtual environments, this difference is in most cases caused by simulating a generic architecture (hence no CPU type) instead of directly using the host CPU (the exact type is displayed). Virtualizing generic CPUs gives a lot more flexibility from an administrative standpoint and is preferred on most shared resource systems, as VMs can easily be moved between different host systems and the workload can be shares between different CPUs. The drawback is, that no CPU specific functions (like MSR) are available.

@philipheinisch
Copy link
Member

Can we merge this now or do we want to add more as part of this PR?

@ranocha
Copy link
Member Author

ranocha commented Mar 14, 2019

I think you can merge this now.

@philipheinisch philipheinisch merged commit 80c1c1d into IANW-Projects:master Mar 14, 2019
@ranocha ranocha mentioned this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants