Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBS signatures #16

Closed
wants to merge 3 commits into from
Closed

RBS signatures #16

wants to merge 3 commits into from

Conversation

drnic
Copy link

@drnic drnic commented Oct 16, 2023

  • Add sig/tiktoken_ruby.rbs signatures
  • Introduce steep check
  • Run steep check in default rake task
  • Run steep check in github ci
  • README instructions for libraries using tiktoken_ruby
  • Confirm library "tiktoken_ruby" works for client of gem via bundle exec steep check

@drnic
Copy link
Author

drnic commented Oct 16, 2023

FWIW this is the first time I've added .rbs sigs into someone else's gem (because I decided to use .rbs in my own WIP gem and figured I'd be helpful :)

@drnic
Copy link
Author

drnic commented Oct 16, 2023

NOTE, the BpeFactory signatures weren't required by steep check, but I figured out what I think they should be from the extension.

@IAPark
Copy link
Owner

IAPark commented Apr 4, 2024

Thanks @drnic sorry for never merging this, trying to be more helpful with my own stuff, but still slow. If you'd like to merge this still let me know and I'll reopen this PR

@IAPark IAPark closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants