Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-aid-type defaults to CashandVoucherModalities vocabulary #567

Open
stevieflow opened this issue Nov 19, 2019 · 1 comment
Open

Comments

@stevieflow
Copy link
Contributor

Describe the bug
The analysis of default-aid-type defaults to the CashandVoucherModalities vocabulary, meaning that those that used the documented default vocabulary are flagged

See: http://dashboard.iatistandard.org/codelist/2/default-aid-type_@code.html

To Reproduce
Steps to reproduce the behavior:
Go to http://dashboard.iatistandard.org/codelist/2/default-aid-type_@code.html

See example publisher: http://dashboard.iatistandard.org/publisher/afdb.html#p_codelists

Expected behavior
A publisher should be checked against values on the default vocabulary: http://reference.iatistandard.org/203/codelists/AidType/

Additional context
Note - I do not think this is related to #174 - as the issue here is that the default seems to have changed

@andylolz
Copy link
Contributor

I think the code in question was created before there were multiple mappings for the same path.

I’ve sent a fix that checks the condition for a mapping. If there’s a condition in place, and it’s not the default, the mapping is ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants