Merge pull request #300 from andylolz/remove-superfluous-line

Remove weird line in create_app that’s just there to make the test suite work; do it The Correct Way™ in the test setUp instead
IATI · Jun 18, 2018 · 3941158 · 3941158
2 parents efdab1f + 0d7ccb6
commit 3941158
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/iati_datastore/iatilib/frontend/__init__.py b/iati_datastore/iatilib/frontend/__init__.py
@@ -22,7 +22,6 @@ def create_app(**config):
             'RQ_DEFAULT_PASSWORD': app.config['REDIS_PASSWORD']
         })
 
-    db.app = app  # don't understand why I need to this
     db.init_app(app)
     redis.init_app(app)
 

diff --git a/iati_datastore/iatilib/test/__init__.py b/iati_datastore/iatilib/test/__init__.py
@@ -32,6 +32,8 @@ def setUp(self):
                     'sqlite:///:memory:',
                 )
             )
+            _app.app_context().push()
+
         self.app = _app
         if os.environ.get("SA_ECHO", "False") == "True":
             db.engine.echo = True