This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
Support iatistandard 2.01 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make the raw XML test pass * Update the 2.01 sample XML to include Steven's recent fixes: IATI/IATI-Extra-Documentation#287 * Add note to explain why region name test isn't working
Updates the `iati download_codelists` command to fetch these.
(This is taken from iati-activities/@Version)
These have either been done, or are covered by the GitHub issue.
(sector, recipient-country, recipient-region)
|
The code is now running on the dev datastore: BUT, there seem to be some problems with the import (there are far fewer activities than in the live datastore). I will investigate this next week. I don't anticipate this being too tricky to fix, but it may take some time to do the reimport a few times (to test), so my current planned timeframe for putting the changes live is now the end of next week. |
|
The import problems seem to be due to having more than one worker: I've now reimported using only one server, and it seems to have worked much better: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests add support for 2.01 to the datastore. Whilst doing this, the following additional changes have been made:
iati-extranamespace has been added, and used to place the version from iati-activities onto the iati-activity-elementNote that there is also some 2.01 related work that I have put off for now, since I don't think it's as important, and we are very short on developer time at the moment:
https://github.com/IATI/iati-datastore/milestones/Improving%202.01%20Support
I will deploy this code to the development copy of the datastore tomorrow, and if that goes as planned, to the live server next week.