This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
Add test for CSV route checking #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default is never used, so can be safely removed.
andylolz
force-pushed
the
250-stricter-routes
branch
from
1fed0b9
to
07d3334
Compare
hayfield
reviewed
Jun 7, 2017
| @@ -222,7 +222,7 @@ def get(self, format): | |||
|
|
|||
|
|
|||
| class DataStoreCSVView(DataStoreView): | |||
| def get(self, format=".csv"): | |||
| def get(self, format): | |||
There was a problem hiding this comment.
Note: removal of default due to being superfluous #258 (comment)
hayfield
approved these changes
Jun 7, 2017
|
Ooh – #258 is merged now 🚀 IIRC, this PR just adds tests to cover the new stuff that was in that PR (as requested by @hayfield here: #258 (review)). |
allthatilk
approved these changes
Jun 4, 2018
|
@andylolz if you could merge in latest changes from |
|
@allthatilk done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests that fails before 199d9dd and pass after.
Also removes default parameter value since it is not used.
Refs #258; Fixes #250.